Conversation
Anthelixes
left a comment
There was a problem hiding this comment.
@liviuedw Please include a README.md. See other sub-modules.
| - field.storage.paragraph.field_reverse | ||
| - paragraphs.paragraphs_type.parallax_component | ||
| id: paragraph.parallax_component.field_reverse | ||
| field_name: field_reverse |
There was a problem hiding this comment.
I think field_reverse_layout would be better, to match the same naming pattern with field_vertical_layout.
| theme: | ||
| css/parallax-component.css: {} | ||
| js: | ||
| https://cdnjs.cloudflare.com/ajax/libs/gsap/3.12.5/gsap.min.js: {} |
There was a problem hiding this comment.
Please try to import the library using composer. Here is the archive: https://github.com/greensock/GSAP/releases/tag/3.12.5
You can import using composer on each project:
"type": "package",
"package": {
"name": "greensock/gsap",
"version": "3.12.5",
"type": "drupal-library",
"dist": {
"url": "https://github.com/greensock/GSAP/archive/refs/tags/3.12.5.zip",
"type": "zip"
}
}
},
and then run composer require greensock/gsap.
Then in edw_paragraphs_parallax_component.libraries.yml replace the external url with the path to the library i.e: /library/gsap/...
Please document the stepts in a README.md.
| status: true | ||
| dependencies: { } | ||
| id: parallax_component | ||
| label: 'Parallax Section' |
There was a problem hiding this comment.
Please update de label to: Parallax component
…t, add GSAP via composer, and include README.md
bc2620b to
4a5e08d
Compare
No description provided.