Skip to content

refs #33355 - Separate tabs into blocks#13

Open
sosig132 wants to merge 2 commits into1.xfrom
33355-tabs-blocks
Open

refs #33355 - Separate tabs into blocks#13
sosig132 wants to merge 2 commits into1.xfrom
33355-tabs-blocks

Conversation

@sosig132
Copy link
Contributor

No description provided.

@@ -34,3 +34,12 @@ slots:
slot_content:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the slots are actually rendered, they aren't associated with the block tags, we should remove them.

container:
title: Container
description: Container wrapper for the Horizontal Tabs.
tabs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name this "nav" to align with the structure from L42 and L54


{# Change attributres #}
{# Render component #}
{% block container %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This container block isn't necessary, we need to add the scrollable

here
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants