fix(): popover组件新增configProps属性 Closes MONITOR-10409#528
Merged
Conversation
工作流程为 PopoverContainer 添加可选 变更
估计代码审查工作量🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@bricks/basic-bricks/src/popover-container/PopoverContainer.tsx`:
- Around line 188-198: The current spread of props.configProps can overwrite
critical Popover props; change the JSX so props.configProps is spread first and
then explicitly set Popover props (title via BrickAsComponent, visible,
placement, content, trigger, onVisibleChange, etc.) are spread after it so those
controlled values cannot be clobbered; locate the block using
props.popoverTitleBrick?.useBrick, props.configProps and BrickAsComponent in
PopoverContainer.tsx and reorder the spreads so explicit props follow
props.configProps.
🧹 Nitpick comments (1)
bricks/basic-bricks/src/popover-container/index.tsx (1)
308-311: 缺少 JSDoc 文档注释。其他属性都有完整的 JSDoc 文档(包括
@kind、@required、@default、@description、@group等注解),但configProps缺少这些文档。这会影响自动生成的文档和开发者体验。📝 建议添加文档注释
+ /** + * `@kind` Record<string, any> + * `@required` false + * `@default` {} + * `@description` 透传给 Popover 组件的额外配置属性 + * `@group` basic + */ `@property`({ attribute: false, }) configProps: Record<string, any> = {};
5286d81 to
422d17a
Compare
panzekun
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
依赖检查
组件之间的依赖声明,是微服务组件架构下的重要信息,请确保其正确性。
请勾选以下两组选项其中之一:
或者:
提交信息检查
Git 提交信息将决定包的版本发布及自动生成的 CHANGELOG,请检查工作内容与提交信息是否相符,并在以下每组选项中都依次确认。
破坏性变更:
feat作为提交类型。BREAKING CHANGE: 你的变更说明。新特性:
feat作为提交类型。问题修复:
fix作为提交类型。杂项工作:
即所有对下游使用者无任何影响、且没有必要显示在 CHANGELOG 中的改动,例如修改注释、测试用例、开发文档等:
chore,docs,test等作为提交类型。Summary by CodeRabbit
发布说明
新功能
改进