Skip to content

chore(deps): update dependency ws to 7.4.6 [security] - abandoned - autoclosed#80

Closed
renovate[bot] wants to merge 1 commit intomasterfrom
renovate/npm-ws-vulnerability
Closed

chore(deps): update dependency ws to 7.4.6 [security] - abandoned - autoclosed#80
renovate[bot] wants to merge 1 commit intomasterfrom
renovate/npm-ws-vulnerability

Conversation

@renovate
Copy link

@renovate renovate bot commented Nov 23, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change
ws 7.3.1 -> 7.4.6

GitHub Vulnerability Alerts

CVE-2021-32640

Impact

A specially crafted value of the Sec-Websocket-Protocol header can be used to significantly slow down a ws server.

Proof of concept

for (const length of [1000, 2000, 4000, 8000, 16000, 32000]) {
  const value = 'b' + ' '.repeat(length) + 'x';
  const start = process.hrtime.bigint();

  value.trim().split(/ *, */);

  const end = process.hrtime.bigint();

  console.log('length = %d, time = %f ns', length, end - start);
}

Patches

The vulnerability was fixed in ws@7.4.6 (websockets/ws@00c425e) and backported to ws@6.2.2 (websockets/ws@78c676d) and ws@5.2.3 (websockets/ws@76d47c1).

Workarounds

In vulnerable versions of ws, the issue can be mitigated by reducing the maximum allowed length of the request headers using the --max-http-header-size=size and/or the maxHeaderSize options.

Credits

The vulnerability was responsibly disclosed along with a fix in private by Robert McLaughlin from University of California, Santa Barbara.


Configuration

📅 Schedule: "" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.163% when pulling 4f3d46b on renovate/npm-ws-vulnerability into 855da5d on master.

@renovate renovate bot changed the title chore(deps): update dependency ws to 7.4.6 [security] chore(deps): update dependency ws to 7.4.6 [security] - abandoned Jun 1, 2023
@renovate
Copy link
Author

renovate bot commented Jun 1, 2023

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

@renovate renovate bot changed the title chore(deps): update dependency ws to 7.4.6 [security] - abandoned chore(deps): update dependency ws to 7.4.6 [security] - abandoned - autoclosed Sep 1, 2024
@renovate renovate bot closed this Sep 1, 2024
@renovate renovate bot deleted the renovate/npm-ws-vulnerability branch September 1, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants