Skip to content

change NVHPCToolchain deprecation warning to simple warning in unit tests#5105

Merged
boegel merged 4 commits intoeasybuilders:developfrom
lexming:fix-nvhpc-ci
Feb 4, 2026
Merged

change NVHPCToolchain deprecation warning to simple warning in unit tests#5105
boegel merged 4 commits intoeasybuilders:developfrom
lexming:fix-nvhpc-ci

Conversation

@lexming
Copy link
Contributor

@lexming lexming commented Feb 4, 2026

CI test suite in easybuild-easyconfigs is currently broken due to this deprecation warning adn the recent changes in #5103.

Instead of mending the tens of test failing, we can avoid the error altogether by switching to a regular warning in the test suite.

@lexming lexming added the tests label Feb 4, 2026
@lexming lexming added this to the next release (5.2.1?) milestone Feb 4, 2026
@lexming lexming requested a review from bartoldeman February 4, 2026 19:11
boegel
boegel previously approved these changes Feb 4, 2026
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this to avoid too much trouble in easyconfigs CI, but inspect should be used with care, it's quite slow...

@boegel boegel added the bug fix label Feb 4, 2026
@boegel boegel enabled auto-merge February 4, 2026 19:16
bartoldeman
bartoldeman previously approved these changes Feb 4, 2026
Copy link
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bartoldeman
Copy link
Contributor

CI fails in the check for the deprecation message now, maybe simplest to remove that check, since it's already checked elsewhere?

@lexming lexming dismissed stale reviews from bartoldeman and boegel via a70fa6e February 4, 2026 20:20
@lexming lexming changed the title disable NVHPCToolchain deprecation warning in unit tests change NVHPCToolchain deprecation warning to simple warning in unit tests Feb 4, 2026
@lexming lexming requested a review from bartoldeman February 4, 2026 21:37
Copy link
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boegel boegel merged commit 079a8d3 into easybuilders:develop Feb 4, 2026
40 checks passed
@lexming lexming deleted the fix-nvhpc-ci branch February 4, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants