Don't install test.framework package#5070
Don't install test.framework package#5070Flamefire wants to merge 3 commits intoeasybuilders:developfrom
test.framework package#5070Conversation
0762228 to
d0943f2
Compare
test.framework package
This results in a top-level Python package called "test". As this isn't namespaced to easybuild it can cause issues with other Python packages and shouldn't be installed.
When we no longer install the test package AND want to run outside the source tree (to test the installed easybuild package) we need to retrieve the test package first.
We need to use `$PYTHONPATH` instead of `topdir` to include the framework package in the GC3Pie test. When testing copies of framework files we need to handle the case where some might not be available and try hard to find the source dir.
d0943f2 to
fd77d35
Compare
|
I agree that namespace-wise this isn't nice, but I think there's some value in includes the tests with the installation. This is a "feature" for a long time now, see also https://docs.easybuild.io/unit-tests/#unit_tests_running If we want to change this, we need some kind of migration path, for example change the namespace to |
I'd say 99% of users do not need nor want the tests, even though they don't take much space
From how I read it nothing there states that the unit tests are installed / part of the distribution package, only that there are unit tests, how to run them and that they are run on CI. And running the tests isn't something so important that we need a deprecation period if any process is easily adapted. We can just update the documentation. Some guides (1 & [2] use a So I'd say we go with the latter: |
This results in a top-level Python package called "test". As this isn't namespaced to easybuild it can cause issues with other Python packages and shouldn't be installed.
Additionally IMO it isn't useful to install the tests in the first place.