pick up on config.cfg EasyBuild configuration file in current working directory#5054
Open
j3mdamas wants to merge 2 commits intoeasybuilders:developfrom
Open
pick up on config.cfg EasyBuild configuration file in current working directory#5054j3mdamas wants to merge 2 commits intoeasybuilders:developfrom
config.cfg EasyBuild configuration file in current working directory#5054j3mdamas wants to merge 2 commits intoeasybuilders:developfrom
Conversation
boegel
requested changes
Dec 3, 2025
| '', | ||
| "[with $XDG_CONFIG_HOME: %s, $XDG_CONFIG_DIRS: %s]" % (xdg_config_home, xdg_config_dirs), | ||
| '', | ||
| "* local-level: %s" % os.path.join('.', 'config.cfg'), |
Member
There was a problem hiding this comment.
I would change this to avoid confusion:
Suggested change
| "* local-level: %s" % os.path.join('.', 'config.cfg'), | |
| "* current working directory: %s" % os.path.join('.', 'config.cfg'), |
| DEFAULT_SYS_CFGFILES = [sorted(glob.glob(os.path.join(d, 'easybuild.d', '*.cfg'))) | ||
| for d in XDG_CONFIG_DIRS] | ||
| DEFAULT_USER_CFGFILE = os.path.join(XDG_CONFIG_HOME, 'easybuild', 'config.cfg') | ||
| DEFAULT_LOCAL_CFGFILE = os.path.join(os.path.normpath(os.getcwd()), 'config.cfg') |
Member
There was a problem hiding this comment.
Maybe rename to DEFAULT_CWD_CFGFILE, or DEFAULT_CURRENT_WORKING_DIR_CFGFILE if that's not clear enough?
I think "local" could be interpreted differently
boegel
changed the title
config.cfg EasyBuild configuration file in current working directory
Author
|
@boegel just wanted to note ahead of the EB conf call that this is not forgotten, I just didn't have the opportunity to address your questions. I'll come back to it. |
Member
OK, thank you, no worries :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3965
I used git config as a reference: https://git-scm.com/docs/git-config#SCOPES
(there they call the easybuild user scope global scope, but we don't need to change that)
I ran some small tests locally with
eb --show-default-configfilesandeb --show-configand everything seems to work as expected, but I don't know if there are some unit tests I should create.tagging: @boegel