Replace assertErrorRegex by standard assertRaisesRegex#5010
Open
Flamefire wants to merge 3 commits intoeasybuilders:developfrom
Open
Replace assertErrorRegex by standard assertRaisesRegex#5010Flamefire wants to merge 3 commits intoeasybuilders:developfrom
assertErrorRegex by standard assertRaisesRegex#5010Flamefire wants to merge 3 commits intoeasybuilders:developfrom
Conversation
Flamefire
force-pushed
the
replace-assertErrorRegex
branch
3 times, most recently
from
6d93182 to
35125ac
Compare
boegel
reviewed
Oct 8, 2025
easybuild/tools/build_log.py
Outdated
|
|
||
| def __str__(self): | ||
| """Return string representation of this EasyBuildError instance.""" | ||
| return repr(self.msg) |
Contributor
Author
There was a problem hiding this comment.
Indeed. Otherwise tests fail due to escaping as we had special handling for that, see convert_exception_to_str
Flamefire
force-pushed
the
replace-assertErrorRegex
branch
from
35125ac to
cb92566
Compare
Member
|
@Flamefire merge conflict to resolve... |
Flamefire
force-pushed
the
replace-assertErrorRegex
branch
2 times, most recently
from
dd9da09 to
9b8b864
Compare
Flamefire
force-pushed
the
replace-assertErrorRegex
branch
from
9b8b864 to
8bd685b
Compare
Flamefire
force-pushed
the
replace-assertErrorRegex
branch
from
8bd685b to
118327d
Compare
Contributor
Author
|
Rebased only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We no longer need this custom function with Python 2 support being dropped.
The only remaining use case was
EasyBuildErrorwherestr(e)didn't return the error as a string but as an escaped string.See also #5009 which fixes that (single relevant commit included here to avoid test failures)
This makes it easier to use, especially for new devs being used to the
unittestmodule and conventions for other functions likeself.assertRaises.Additionally this can be used as a context manager: