Proposed changest to add a timeout to run_shell_cmd#4665
Open
Crivella wants to merge 8 commits intoeasybuilders:developfrom
Open
Proposed changest to add a timeout to run_shell_cmd#4665Crivella wants to merge 8 commits intoeasybuilders:developfrom
timeout to run_shell_cmd#4665Crivella wants to merge 8 commits intoeasybuilders:developfrom
Conversation
Member
ebba4d8 to
85f5e44
Compare
Contributor
Author
|
I've rebased this on top of the latest 5.0.x and adapted the code to use the changes introduced by #4755 |
Member
85f5e44 to
6df5557
Compare
Member
6df5557 to
7d71efb
Compare
…amed to `read_process_pipe`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes would implement the capability for
run_shell_cmdto fail after a user-specifiedtimeout.This would be useful for commands that are known to possibly hang to fail gracefully and report meaningful logs, instead of blocking EB indefinitely.
The PR leverages the already implemented timeout in Popen.communicate (since python 3.3) for non-interactive/streamed usage of
run_shell_cmdIn case of an interactive/streamed run the following has been added:
run.pyread_pipe: read from a pipe using a thread and raise aTimeoutErrorin case the read operation is taking longer than the specified timeoutterminate_process: attempt to terminate a process gracefully by usingPopen.terminatefirst andPopen.killafter. Raises an EasybuildError if the process is still alive aftertimeoutrun_shell_cmdtimeouttimetimeouttimeout