Simplify use/unuse in Lmod#3634
Closed
Flamefire wants to merge 3 commits intoeasybuilders:developfrom
Closed
Conversation
Lmod ignores if a path exists so we should be able to do the same
Introduce _set_module_path which correctly handles empty paths and empty lists with proper logging
This was referenced Apr 6, 2021
Contributor
Author
|
Closed as included in #3636 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This basically moves the common functionality of use and unuse into
_set_module_pathwhich takes care of proper logging and handling empty paths. Note that an empty string is different to no path, i.e.$MODULEPATH=''is different tounset MODULEPATHin Lmod. Checked withmodule use ''which yields a set, but empty MODULEPATH and amodule unused $MODULEPATHremove that variable completelyNot fully sure if there was a bug before, but now there provably is not due to the enhanced tests :)