handle github api pagination when present (WIP)#2776
Open
migueldiascosta wants to merge 7 commits intoeasybuilders:developfrom
Open
handle github api pagination when present (WIP)#2776migueldiascosta wants to merge 7 commits intoeasybuilders:developfrom
migueldiascosta wants to merge 7 commits intoeasybuilders:developfrom
Conversation
houndci-bot
reviewed
Feb 20, 2019
Member
Author
|
I'm not particularly happy about the parsing of |
boegel
requested changes
Feb 20, 2019
Member
boegel
left a comment
There was a problem hiding this comment.
@migueldiascosta This looks fairly OK to me, I don't see a better option w.r.t. grabbing the page count, since they do something very similar in https://developer.github.com/v3/guides/traversing-with-pagination/...
boegel
reviewed
Feb 21, 2019
Member
|
The code on which the rest code from vsc-base is based on has full pagination support since the beginning of this year: mozilla/agithub#49 So we might as well update the code in vsc-base and use that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alternative to #2553
needs
vsc-base2.8.4