Always setup config for vendored crates in Cargo easyblock#4018
Open
Flamefire wants to merge 1 commit intoeasybuilders:developfrom
Open
Always setup config for vendored crates in Cargo easyblock#4018Flamefire wants to merge 1 commit intoeasybuilders:developfrom
Flamefire wants to merge 1 commit intoeasybuilders:developfrom
Conversation
Flamefire
force-pushed
the
cargo-offline
branch
from
75fb3e9 to
8124940
Compare
Member
|
@Micket Can you take a look at this? |
Contributor
Author
|
Maybe test together with #3995 |
Member
|
@Flamefire Can you sync this with |
Flamefire
force-pushed
the
cargo-offline
branch
from
8124940 to
3c17329
Compare
Contributor
Author
|
@boegel rebased |
Previously having `offline = False` skipped creating the checksum files for downloaded crates and adjusting the `$CARGO_HOME/config.toml` file to point to them causing them to be (almost silently) ignored. Now always set up the config files for vendored crates and log information when `crates != not offline`, which looks suspicious at least.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously having
offline = Falseskipped creating the checksum files for downloaded crates and adjusting the$CARGO_HOME/config.tomlfile to point to them causing them to be (almost silently) ignored.Now always set up the config files for vendored crates and log information when
crates != not offline, which looks suspicious at least.This resolves the question raised in easybuilders/easybuild-easyconfigs#24643 which fixes an EasyConfig that has (many) crates specified but with
offline = Falsecausing them to be downloaded, extracted and then ignored.As the result they will be downloaded which fails as the new versions available by now are not compatible with the used Rust version anymore