-
Notifications
You must be signed in to change notification settings - Fork 2
Add option to use Google Cloud bucket #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for the great feature idea 😊 |
|
#6 This is my feedback regarding this issue. |
|
|
||
| return `\n<img src="${imageUrl}" width="${size}"/>\n`; | ||
| } | ||
| return ``; | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This raises a question for me.
For additional context, see the discussion here:
#6 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this structure displays well in Obsidian. Other plugins I use, such as Imgur, also previously used this format. However, when I publish to a Markdown-based blog, all embedded images are broken. I had to revert to the other format for them to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand your point. However, there also seem to be many platforms that do not support Markdown-style image sizing, so there appears to be a trade-off.
Since images are currently breaking on the platform you’re using, we’ll go with your approach for now and track this separately by opening an additional ticket later.
LGTM 👍
I am developing additional features to facilitate Google Cloud bucket configuration with CDN, thereby enhancing load speed. This is well-suited for enterprise documentation and for scenarios involving a higher monthly volume of image uploads.