Skip to content

Conversation

@leolionart
Copy link

I am developing additional features to facilitate Google Cloud bucket configuration with CDN, thereby enhancing load speed. This is well-suited for enterprise documentation and for scenarios involving a higher monthly volume of image uploads.

@easternkite
Copy link
Owner

@leolionart

Thanks for the great feature idea 😊
Could you please create a related issue first?
Discussing the context there will help us review and align the change better.

@easternkite easternkite self-requested a review December 12, 2025 03:11
@leolionart
Copy link
Author

leolionart commented Dec 12, 2025

#6 This is my feedback regarding this issue.

leolionart

This comment was marked as duplicate.

Comment on lines -54 to +32

return `\n<img src="${imageUrl}" width="${size}"/>\n`;
}
return `![${size}](${imageUrl})`;
};
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This raises a question for me.
For additional context, see the discussion here:
#6 (comment)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this structure displays well in Obsidian. Other plugins I use, such as Imgur, also previously used this format. However, when I publish to a Markdown-based blog, all embedded images are broken. I had to revert to the other format for them to work.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand your point. However, there also seem to be many platforms that do not support Markdown-style image sizing, so there appears to be a trade-off.

Since images are currently breaking on the platform you’re using, we’ll go with your approach for now and track this separately by opening an additional ticket later.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants