Open
Conversation
Signed-off-by: Rob Johnson <rob@robjohnson.io>
Signed-off-by: Rob Johnson <rob@robjohnson.io>
Signed-off-by: Rob Johnson <rob@robjohnson.io>
Signed-off-by: Rob Johnson <rob@robjohnson.io>
Signed-off-by: Rob Johnson <rob@robjohnson.io>
Signed-off-by: Rob Johnson <rob@robjohnson.io>
Signed-off-by: Rob Johnson <rob@robjohnson.io>
Signed-off-by: Rob Johnson <rob@robjohnson.io>
fawazahmed0
added a commit
to fawazahmed0/maximize-build-space
that referenced
this pull request
Jan 30, 2026
|
FYI I merged this PR into a fork of this action and have confirmed it resolves the issue. |
Signed-off-by: Rob Johnson <rob@robjohnson.io>
Signed-off-by: Rob Johnson <rob@robjohnson.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed that some runners don't have /mnt. They generally have a large / partition, so the lvm trick won't work and isn't needed for these runners.
Even worse, in the current code, this causes the script to miscalculate the appropriate size of the lvm image file, filling the root partition and causing the job to fail.
This PR adds a simple check for the existence of /mnt and skips the LVM creation and setup when /mnt is not present.