Skip to content

Use generated URLs rather than constant URLs. #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
calvin wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use generated URLs rather than constant URLs. #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac7b1dd
Use generated URLs rather than constant URLs.
calvin Sep 21, 2014
a2cb850
Proivde `User-Agent` header
calvin Sep 27, 2014
965afc9
addinfourl instance has no attribute '__exit__'
calvin Sep 27, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion earthreader/web/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from six.moves import urllib

from flask import Flask, jsonify, render_template, request, url_for
from libearth import version
from libearth.codecs import Rfc3339
from libearth.compat import text_type
from libearth.crawler import crawl
Expand Down Expand Up @@ -166,7 +167,10 @@ def add_feed(category_id):
cursor = Cursor(category_id)
url = request.form['url']
try:
f = urllib.request.urlopen(url)
rq = urllib.request.Request(url)
rq.add_header('User-Agent', '{0}/{1}'.format(version.__package__,
version.VERSION))
f = urllib.request.urlopen(rq):
document = f.read()
f.close()
except Exception:
Expand Down
4 changes: 2 additions & 2 deletions earthreader/web/templates/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,14 @@ <h1>Earth Reader</h1>
<li class="fold">
<div class="form">
<h2>Add Feed</h2>
<form action="/feeds/" class="addFeed" data-after="makeFeedList">
<form action="{{ url_for('.feeds', method='POST') }}" class="addFeed" data-after="makeFeedList">
<input type="url" name="url" placeholder="URL"/>
<input type="submit" value="Add"/>
</form>
</div>
<div class="form">
<h2>Add Category</h2>
<form action="/" class="addCategory" data-after="makeFeedList">
<form action="{{ url_for('.add_category', method='POST') }}" class="addCategory" data-after="makeFeedList">
<input type="text" name="title" placeholder="title"/>
<input type="submit" value="Add"/>
</form>
Expand Down