add Sensor class with clear data model #4
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data collection / sensor management data were handled in a very strange fashion:
create_collection.py, was used to define the collections in a python dictionary.earthlib/data/collections.jsonThis is all very silly. This refactor creates a
dataclassobject that defines the key properties we need to track for the different earth observing sensors we support. This keeps everything in python, and does not require tracking and including data files.This MR deletes the collections.json file, the script for generating it, the make target, and simplifies some patterns around getting key pairs.