Open
Conversation
Fixes #120 Co-authored: @toto101230
ear1grey
requested changes
May 10, 2021
Owner
ear1grey
left a comment
There was a problem hiding this comment.
This looks good, though the use of Excel is a surprise.
For maintainability going forward we'll need two key changes.
- The code should read values directly from this spreadsheet using the Google sheets API. (We can set the sheet to be readable by anyone, so only named editors can amend it.)
- If any of the locales marked as ready does not contain a complete list of translations the program should
process.exit(100)so we can include this in the release process and the build ill not succeed if the languages marked as released are not fully translated. This potentially makes the release process longer as more languages are added, but it means the interface won't break for anyone once a locale is released.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a hard time finding a bookstore that met the import requirements you mentioned.
But we finally found a library that allowed us to do so.
To do the translations, you have to download the xlsx file in the extension directory and then run the npm i18 script.
Fixes #120
Co-authored: @toto101230