Skip to content

adds nodejs support#2

Open
idkjs wants to merge 1 commit intoeWert-Online:masterfrom
idkjs:node
Open

adds nodejs support#2
idkjs wants to merge 1 commit intoeWert-Online:masterfrom
idkjs:node

Conversation

@idkjs
Copy link

@idkjs idkjs commented Jan 8, 2021

Nice project. Thanks for sharing it.

You probably dont need it but here it is anyway. I added a few line to check if on browser or node and select XmlRequest based on the environment.

@eWert-Online
Copy link
Owner

Hey 👋
thank you for creating this pr.
What problem does this solve exactly? 😊

@idkjs
Copy link
Author

idkjs commented Jan 9, 2021

I tried using your lib to run some xmlrequests to test some queries and it failed. Figured just patch it which I did but trying to be a good netizen and sharing it. Thanks again for sharing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants