[23858] Build with warnings as errors (backport #289)#291
Merged
MiguelCompany merged 1 commit into1.0.xfrom Oct 31, 2025
Merged
[23858] Build with warnings as errors (backport #289)#291MiguelCompany merged 1 commit into1.0.xfrom
MiguelCompany merged 1 commit into1.0.xfrom
Conversation
Author
|
Cherry-pick of 9beec7e has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
10 tasks
Member
|
@Mergifyio rebase |
Author
✅ Branch has been successfully rebased |
ac59440 to
5ebf896
Compare
* Refs #23858. Build with warnings as errors. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #23858. Add option for MSVC Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #23858. Fix warning. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #23858. Move to CI Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Apply suggestion Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Ricardo González <correoricky@gmail.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> Signed-off-by: Ricardo González <correoricky@gmail.com> Co-authored-by: Ricardo González Moreno <ricardo@richiware.dev> (cherry picked from commit 9beec7e) # Conflicts: # test/SimpleTest.cpp
5ebf896 to
7de4ab1
Compare
MiguelCompany
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Just what the title says. We want builds to fail if there are warnings.
@Mergifyio backport 2.2.x 1.0.x
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist
This is an automatic backport of pull request #289 done by [Mergify](https://mergify.com).