Use asio::strand to serialize asio::async_write() and asio::async_read() on same asio::ssl::stream object when ssl and steaming mode are both enabled #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greensky00
reviewed
Dec 1, 2025
src/asio_service.cxx
Outdated
| class aa { | ||
| public: | ||
| template<typename BB, typename FF> | ||
| template<typename BB, typename FF, typename Strand = void*> |
Contributor
There was a problem hiding this comment.
I think Strand = void will be better. Both work (void* vs void** in case when nullptr is passed) though.
Contributor
Author
There was a problem hiding this comment.
Yes. Fix done. Force push the pr.
…d() on same asio::ssl::stream object when ssl and steaming mode are both enabled
shigui1990
force-pushed
the
branch_fix_ssl_streaming_mode
branch
from
8b13512 to
6e0c944
Compare
shigui1990
changed the title
asio::strand to serialize asio::async_write() and asio::async_read() on same asio::ssl::stream object when ssl and steaming mode are both enabled
shigui1990
changed the title
asio::strand to serialize asio::async_write() and asio::async_read() on same asio::ssl::stream object when ssl and steaming mode are both enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSL_write()andSSL_read()on same SSL object, e.g. one SSL socket, are not thread-safeasio::async_write()andasio::async_read()on sameasio::ssl::streamobject are not thread-safeasio::strandto serializeasync_write()andasync_read()calls on same ssl stream object.