-
Notifications
You must be signed in to change notification settings - Fork 24
Add interface to add client data rpc #846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add interface to add client data rpc #846
Conversation
bf220c9 to
b069b44
Compare
| // becoming a leader. | ||
|
|
||
| RD_LOGD(NO_TRACE_ID, "become_leader_cb: setting traffic_ready_lsn from {} to {}", current_gate, new_gate); | ||
| m_listener->on_become_leader(m_group_id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious about the purpose of on_become_xxx. Should we move it to the beginning of become_xxx_cb to call the upper callback first, similar to how handle_commit does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on_become_leader and on_become_follower will be used for homeobject scrubbing. when scrubbing is on-going, if leader switch happens, the old leader will become follower and thus on_become_follower will be called on this node, where we stop the scrubbing thread that will request scrub results from the other two members. one of the follower will become leader and thus on_become_leader will be called on this node, where we will read the scrub superblk and start the scrubbing thread to request scrub result from the other two memebers.
Should we move it to the beginning
no need to do this now, what we want is to make sure that we can be notified with the leader change event, it does not matter it is called in the beginning or end.
|
Can we do a POC regarding the required communication primitives We can to the POC of HO in HS UT (which is easier to implement RepldevListener), that gives team better understanding the requirements |
|
I am now working on the POC code with this change to see if this is workable |
b069b44 to
2ee228f
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #846 +/- ##
==========================================
- Coverage 56.51% 49.05% -7.46%
==========================================
Files 108 110 +2
Lines 10300 11468 +1168
Branches 1402 5430 +4028
==========================================
- Hits 5821 5626 -195
+ Misses 3894 2209 -1685
- Partials 585 3633 +3048 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
expose nuraft_message to upper layer, so that they can register their own rpc call by calling
bind_data_service_request