Skip to content

[wip] Fsync pdev in vdev cp. #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
xiaoxichen wants to merge 1 commit into
base: fix_cp
Choose a base branch
from
Draft

[wip] Fsync pdev in vdev cp. #565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/lib/device/virtual_dev.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,13 +574,13 @@ folly::Future< std::error_code > VirtualDev::queue_fsync_pdevs() {
assert(m_pdevs.size() > 0);
if (m_pdevs.size() == 1) {
auto* pdev = *(m_pdevs.begin());
HS_LOG(TRACE, device, "Flushing pdev {}", pdev->get_devname());
HS_LOG(DEBUG, device, "Flushing pdev {}", pdev->get_devname());
return pdev->queue_fsync();
} else {
static thread_local std::vector< folly::Future< std::error_code > > s_futs;
s_futs.clear();
for (auto* pdev : m_pdevs) {
HS_LOG(TRACE, device, "Flushing pdev {}", pdev->get_devname());
HS_LOG(DEBUG, device, "Flushing pdev {}", pdev->get_devname());
s_futs.emplace_back(pdev->queue_fsync());
}
return folly::collectAllUnsafe(s_futs).thenTry([](auto&& t) {
Expand Down Expand Up @@ -683,6 +683,13 @@ void VirtualDev::cp_flush(VDevCPContext* v_cp_ctx) {
m_chunk_selector->foreach_chunks(
[this, cp](cshared< Chunk >& chunk) { chunk->blk_allocator_mutable()->cp_flush(cp); });

// fsync the pdev to ensure even pdev open with buffer io, all data we have written prior to this point
// has been persisted to disk.
HS_LOG(DEBUG, device, "in CP flush, fsync-ing pdevs");
auto fut = queue_fsync_pdevs();
std::move(fut).wait();
HS_LOG(DEBUG, device, "in CP flush, pdevs fsync done");

// All of the blkids which were captured in the current vdev cp context will now be freed and hence available for
// allocation on the new CP dirty collection session which is ongoing
for (auto const& b : v_cp_ctx->m_free_blkid_list) {
Expand Down