add bun support #62
Merged
add bun support #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Sorry this has taken a while to review. I'll try get to it this week 👍 |
Contributor
Author
|
It is holidays anyway 👍 |
Contributor
Author
|
@43081j I have fixed all errors |
43081j
reviewed
Jan 19, 2026
43081j
reviewed
Jan 21, 2026
43081j
reviewed
Jan 21, 2026
Contributor
|
last couple of comments but otherwise looks good to me sorry for the slow back and forth on reviews |
Contributor
Author
|
Also should I add any extra tests for this? |
Contributor
|
unfortunately we don't have many good tests right now so we still need to setup the general scaffolding etc. i can try do that some time and we can add them in a follow up branch |
43081j
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.