Skip to content

[enhancement] move SMTP credentials to config#1302

Merged
winiar93 merged 10 commits intomainfrom
feat/4066_adjust_smtp_config
Apr 7, 2026
Merged

[enhancement] move SMTP credentials to config#1302
winiar93 merged 10 commits intomainfrom
feat/4066_adjust_smtp_config

Conversation

@winiar93
Copy link
Copy Markdown
Contributor

@winiar93 winiar93 commented Apr 2, 2026

Summary

Closes #4066

  • SMTP credentials: Secret block now uses AWS credentials instead of Prefect secret block
  • Email notifications: Enabled by providing smtp_credential_secret parameter (string with credential name) in the flow function and replaces the removed enable_notifications parameter
  • Renamed variables:
    • recipientsnotification_recipients
    • smtp_configsmtp_credential_secret
  • Improved logging: Added more detailed logs throughout the flow

Importance

To centralize credentials management

Checklist

This PR:

  • contains a summary of the changes (the "what")
  • links the relevant issue with the Closes #<issue_number> phrase (the "why")
  • adds new tests (if appropriate)
  • updates docstrings for any new functions or function arguments (if appropriate)

@winiar93 winiar93 requested a review from a team as a code owner April 2, 2026 10:51
@winiar93 winiar93 changed the title adjusted smtp parameters in flow [enhancement] move SMTP credentials to config Apr 2, 2026
@winiar93 winiar93 requested review from k-wolski and trymzet April 2, 2026 11:13
@k-wolski
Copy link
Copy Markdown
Contributor

k-wolski commented Apr 2, 2026

LGTM! But it should be checked by Michał/Rafał as well before merge.

Please also bump viadot version, as it's necessary to release that fix.

@winiar93 winiar93 requested a review from Rafalz13 April 2, 2026 12:39
@winiar93
Copy link
Copy Markdown
Contributor Author

winiar93 commented Apr 2, 2026

code was tested, works good after change
image

with adjusted logging which was requested

image

@winiar93 winiar93 requested a review from damianbugajDE April 2, 2026 12:52
Comment thread src/viadot/orchestration/prefect/flows/transform_and_catalog.py Outdated
Comment thread src/viadot/orchestration/prefect/tasks/failed_test_email_notification.py Outdated
@winiar93 winiar93 requested a review from Rafalz13 April 2, 2026 13:19
@winiar93 winiar93 merged commit 6bee459 into main Apr 7, 2026
3 checks passed
@winiar93 winiar93 deleted the feat/4066_adjust_smtp_config branch April 7, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants