Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #34 by automatically disabling isolation when the --pdb flag is used, since the debugger cannot work in subprocesses. The implementation adds a helpful warning that suggests using --no-isolation --pdb explicitly to avoid the warning in the future.
Changes:
- Adds automatic detection of
--pdbflag that disables isolation and warns users - Respects explicit
--no-isolationflag to avoid showing redundant warnings - Adds comprehensive test coverage for the new warning behavior and verifies
--ff(failed-first) works with isolated tests
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/pytest_isolated/grouping.py |
Adds --pdb detection logic that automatically disables isolation and emits a warning when isolated tests are present |
src/pytest_isolated/config.py |
Documents that --pdb is not forwarded to subprocesses and isolation is automatically disabled when detected |
tests/test_options.py |
Adds three new tests: one for --pdb with warning, one for --no-isolation --pdb without warning, and one for --ff functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #34
If user provides
--pdb, the isolation will automatically be disabled and pytest will warn the user to use--no-isolation. Using--no-isolation --pdbshould not trigger the warning.I could not reproduce the
--ffissue