Open
Conversation
… executor support
…eep with sleep(0)
Coverage Report •
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 356b16e. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Updates core flow/node execution to mix native-async and thread-offloaded sync work, which can affect concurrency, timeouts, and context propagation across many node types. Risk is mitigated by added unit/integration coverage but touches critical runtime paths (LLM execution, caching, executor lifecycle).
Overview
Optimizes async runtime execution paths by introducing native async node execution and isolating sync offloading to a per-
Flow.run_asyncContextAwareThreadPoolExecutorpassed down into nodes.Nodes now choose between running
execute_asyncdirectly on the event loop (with newexecute_async_with_retryusingasyncio.wait_for/asyncio.sleep) or falling back torun_syncin an executor with explicitcontextvarspropagation; tools with their own event loops (e.g.CuaDesktopTool,E2BDesktopTool) are forced onto the thread-executor path.Adds async-aware caching via
cache_wf_entity_async(thread-offloading cache I/O), introducesBaseLLM.execute_asyncusinglitellm.acompletion(including async streaming handling), and extends LLM fallback logic to the asyncrun_asyncpath. Tests are updated/added to cover async caching, per-flow executors, node async routing/retry/timeout, and LLM async execution/fallback, with expectations adjusted (e.g., async LLM calls no longer pass a syncclient).Reviewed by Cursor Bugbot for commit 356b16e. Bugbot is set up for automated code reviews on this repo. Configure here.