Fix Next nav button doesnt work on last slide#104
Open
halilnevzat wants to merge 1 commit intodynamicweb:mainfrom
Open
Fix Next nav button doesnt work on last slide#104halilnevzat wants to merge 1 commit intodynamicweb:mainfrom
halilnevzat wants to merge 1 commit intodynamicweb:mainfrom
Conversation
This pull request introduces a dynamic solution to account for cumulative parent element paddings in Swiffy Slider. The changes ensure that the slider functions seamlessly, even when placed inside containers with various padding values. The fix dynamically calculates the cumulative padding of all parent elements and adjusts the slider's CSS variables accordingly, resolving layout and functionality issues in complex DOM structures.
Member
|
Thank you for the pull request and the interest in Swiffy Slider. I am not sure I fully understand exactly what problem this pull request fixes as there is no issue detailing any rendering or layout problems with examples of how to reproduce and explanation of how this pull request would fix said problem. 2 things to consider
Hope you understand my way of thinking. Keep things simple and small, hence effective and easy to deal with. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a dynamic solution to account for cumulative parent element paddings in Swiffy Slider. The changes ensure that the slider functions seamlessly, even when placed inside containers with various padding values. The fix dynamically calculates the cumulative padding of all parent elements and adjusts the slider's CSS variables accordingly, resolving layout and functionality issues in complex DOM structures.
bootstrap container padding right and left caused this problem in my case, i've spent 5 hours to fix this. further tests might be needed.