Skip to content

Conditional 'OR' is not honored #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DWDBE merged 1 commit into from
Feb 27, 2025
Merged

Conditional 'OR' is not honored #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Dynamicweb.DataIntegration.Providers.XmlProvider.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<Version>10.6.3</Version>
<Version>10.6.4</Version>
<AssemblyVersion>1.0.0.0</AssemblyVersion>
<Title>XML Provider</Title>
<Description>XML Provider</Description>
Expand Down
9 changes: 1 addition & 8 deletions src/XMLSourceReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,7 @@ public bool IsDone()

private bool RowMatchesConditions()
{
foreach (MappingConditional conditional in _mapping.Conditionals)
{
if (!_provider.CheckCondition(conditional, _nextRow))
{
return false;
}
}
return true;
return _mapping.Conditionals?.CheckConditionals(_nextRow) ?? true;
}

public Dictionary<string, object> GetNext()
Expand Down