Skip to content

Conversation

@maxnowack
Copy link
Contributor

resolves #31

@maxnowack maxnowack changed the title added support for custom elements and namespaces, fixes #31 added support for custom elements and namespaces Nov 11, 2014
@maxnowack maxnowack mentioned this pull request Dec 4, 2014
@austinpray
Copy link

+1

@dylang
Copy link
Owner

dylang commented Dec 7, 2014

Thank you for doing this! I'm currently traveling with my wife in Istanbul, I hope to merge this when I return in a couple days.

lib/rss.js Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this to:

Object.keys(data.custom_namespaces).forEach(function(name) {
    _attr['xmlns:' + name] = data.custom_namespaces[name];
});

It's a little more functional-style and there won't be a name variable left behind.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done :)

dylang added a commit that referenced this pull request Dec 8, 2014
added support for custom elements and namespaces
@dylang dylang merged commit b921efd into dylang:master Dec 8, 2014
@dylang
Copy link
Owner

dylang commented Dec 8, 2014

I've merged but I'm about to leave for the airport for an 11-hour flight so I don't want to publish until I'm back on the ground in case there are any problems.

@stuartromanek
Copy link

Not to be a bother but any update on publishing this?

@rv-kip
Copy link

rv-kip commented Dec 19, 2014

I've been developing against this PR w/o issue. I did find a couple of minor documentation issues which I corrected in PR #37. Nothing that would delay publishing this though.

@dylang
Copy link
Owner

dylang commented Dec 19, 2014

@stuartromanek Thanks for the nuge - I finally published as 1.1.0!

@rv-kip Thanks for this PR, I've rebuilt the tests using tape, hopefully cleaning them up to make it easier to add new tests. The xml it compares it is now stored in separate xml files that I hope to eventually parse and lint as part of the tests. I'll discuss more in #37.

@stuartromanek
Copy link

@dylang Awesome! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using custom elements

5 participants