This repository was archived by the owner on Jul 17, 2022. It is now read-only.
Notify send custom images#96
Open
flga wants to merge 2 commits intodylang:masterfrom
flga:notify-send-custom-images
Open
Notify send custom images#96flga wants to merge 2 commits intodylang:masterfrom flga:notify-send-custom-images
flga wants to merge 2 commits intodylang:masterfrom
flga:notify-send-custom-images
Conversation
honsa
approved these changes
Dec 1, 2018
|
The commit looks good, just one condition added, if option.image is set use the string to the path otherwise the default image path is used. Please approve this pull request :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows the user to customize the notification image on Linux.
Path resolving is done by node's path.resolve(to).
Relative paths are admissible.
Example: