This repository was archived by the owner on Jul 17, 2022. It is now read-only.
Add support for browser Chrome notifications#101
Open
krustnic wants to merge 12 commits intodylang:masterfrom
Open
Add support for browser Chrome notifications#101krustnic wants to merge 12 commits intodylang:masterfrom
krustnic wants to merge 12 commits intodylang:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new platform - browser Chrome. To use Chrome notifications it is needed to install chrome extension (which creates http server and proxies all requests to Chrome Notifications API).
Since grunt-notify searches for supported platform in certain order Chrome platform may not be used because there may be another supported platform (for example 'notification-center' on Mac OS). So the ability to manually specify which platform you want to use is also added. For this reason new option 'platform' is added. It is an object with two properties: 'name' and 'port' (both are optional), for example: