converted code to Tensorflow 1 and changed skimage range#27
Open
martinosorb wants to merge 1 commit intodyelax:masterfrom
martinosorb:tf1
Open
converted code to Tensorflow 1 and changed skimage range#27martinosorb wants to merge 1 commit intodyelax:masterfrom martinosorb:tf1
martinosorb wants to merge 1 commit intodyelax:masterfrom
martinosorb:tf1
Conversation
Owner
|
Thanks for the PR! Honestly I haven't touched this repo in a while so I'll need to re-download the data, but I'll try to test this and merge this weekend |
Owner
|
Would also definitely be interested in your Python 3 version! |
Author
|
Great, however if I push the py3, it may not be compatible with py2 anymore. Is that ok? |
Owner
|
What did you change to make it work with python3? I’d love to have it be cross-compatible if possible |
Author
|
I used 2to3, which does it automatically, and then ran it to check it worked (I had to make one more change before it did). The 2to3 docs state it's usually not a good idea to try making code compatible with both 2 and 3, but that's up to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code was converted using automatic conversion provided by Tensorflow.
Additionally, the most recent skimage was telling me its images needed to be between -1 and 1, the opposite of what your code and comments said. I changed that, adding a clip since some values were (very slightly) larger than 1.0. This is slightly suspicious...
Note: I also have a python 3 version, which is NOT included in this PR, but you may be interested in.