Introduce a Config object to hold common app configuration#129
Open
danlivings-dxw wants to merge 1 commit intofeature/refactor-nunjucks-viewsfrom
Open
Introduce a Config object to hold common app configuration#129danlivings-dxw wants to merge 1 commit intofeature/refactor-nunjucks-viewsfrom
danlivings-dxw wants to merge 1 commit intofeature/refactor-nunjucks-viewsfrom
Conversation
danlivings-dxw
force-pushed
the
feature/common-app-config
branch
from
fa4f68d to
4634b1b
Compare
danlivings-dxw
force-pushed
the
feature/refactor-nunjucks-views
branch
from
1096806 to
1740f04
Compare
Some properties are required in multiple places (such as the private key, which is used to sign JWTs and by Octokit to authenticate to GitHub), so rather than repeating `process.env` and associated parsing logic throughout the code, this object does it all in one place.
danlivings-dxw
force-pushed
the
feature/common-app-config
branch
from
4634b1b to
1772f34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some properties are required in multiple places (such as the private key, which is used to sign JWTs and by Octokit to authenticate to GitHub), so rather than repeating
process.envand associated parsing logic throughout the code, this object does it all in one place.