-
Notifications
You must be signed in to change notification settings - Fork 0
Drale1/6.x/#526 jquery free and implement dxb slider #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jjroelofs
merged 85 commits into
6.x
from
drale1/6.x/#526-jQuery-free-and-implement-DXB-Slider
Oct 29, 2024
Merged
Changes from all commits
Commits
Show all changes
85 commits
Select commit
Hold shift + click to select a range
96befdd
Added grunt for compiling
2be1f64
Added DXB-Slider to theme
93c9d92
Removed jQuery from Drupal.behaviors.dxpr_themeSettingsColors
05f3c9c
Replaced jQuery vith vanilla JS for no preview icons
8804f2d
Replaced jQuery with vanilla JS for massageValue()
af81b3f
Replaced jQuery with vanilla JS for getCssVariables()
b4e3420
Replaced jQuery with vanilla JS for toggleElement()
447de57
Added roughly DXP-slider
9285b42
Changed dxb-slider.js to work correctly with decimals and modified co…
9f36db9
Styled new sliders
7d1af34
Replaced all sliders from bootstrap to DXB
aad1e2c
Replaced new commit of DXB slider what fixes decimal issues
a35cfd9
Replaced bootstrap-slider relayout() with relayoutSlider()
09cd18b
Replaced jQuery to Vanilla JS in Typographic Scale Master Slider
5972f86
Replaced all jQuery with vanilla JS dxpr-theme-settings.admin.js
4e4fd6d
Fixed all live preview sliders
90eedda
Completely removed the boostrap-slider
531d080
Replaced jQuery with Vanilla JS in dxpr-theme-full-screen-search.js
a969faf
Replaced jQuery with Vanilla JS in dxpr-theme-header.js
6ef503d
Removed all jquery except from animate.css and eslint
c94861e
Replaced animate.css with custom animations-dxpr.css animation
0eb6e03
Removed additional jquery
f79b805
Replaced core/modernizr with vendor/modernizr
98b6308
Merge branch '6.x' into drale1/6.x/#526-jQuery-free-and-implement-DXB…
drale1 99abe1f
Updated DXB Slider with newest version
5733c96
After eslint fix
8e4808e
Added touchstart and Rect in .eslintrc for skipping
2643831
Added shell script for updating DXB-slider and changed dxpr_theme.lib…
ede3a1a
Refactor slider initialization to use direct input elements with 'ran…
5031f71
Resolved merge conflicts between drale1/6.x/#526-jQuery-free-and-impl…
a04c975
Update package-lock.json
deuxcode f2d974a
Fixed scss files using stylelint and page_title-theme-settings.inc
1211672
Fixed issues according to drupal-lint page_title-theme-settings.inc
e5d90e3
Fixed issues according to drupal-lint page_title-theme-settings.inc C…
3f2b85f
Replaced change with input on few places, removed console.log and pre…
562263b
Fixed bug Divider Spacing missing unit px
aae71ce
Added modernizr override and minified
e817d8a
Moved update-dxb-slider.sh to scripts folder
9913219
Returned dxpr-theme-tabs.js lines to Gruntfile.js from remote branch 6.x
f2b9909
Fix live slider update issue: Apply changes immediately while dragging
0d7b83c
Restored core Modernizr dependency and ensured it loads before other …
fb76931
Removed console.log
28f35f5
Removed modernizr from dxpr_theme.libraries.yml
edabd26
Refactor slider initialization by centralizing configuration into a s…
fe8cf92
After eslint fix
2a8a46f
After eslint fix CORRECT
a00f9c2
Returned - core/modernizr as dependency in dxpr_theme.libraries.yml
a99d55e
Removed residual jquery-ui.scss
d9ad0e0
Fixed typography sliders on mobile (<768)
a6846dd
Fixed live slider implementation on Body Font Size, Main menu Font Si…
ce9be39
Fixed live slider Typography > Divider Position
58fcd48
Fixed background typo
8a94374
Commented non existing sliders in dxpr-theme-settings.admin.js and re…
5300076
Prevent sliders box-max-width and layout-max-width to be dynamic
e0b51b9
Removed no preview icon from page-title-breadcrumbs
b7237b8
I've put back a part of the code that works together with the divider…
184ccce
Replaced --dxt-setting- with dynamic cssVarSettingsPrefix constant on…
55c8394
Fixed dynamic sliders on Sticky header Height Background Opacity
0443640
Fixed duplicate slider variables, corrected slider type names, and up…
861210f
After eslint fix
bc53dcf
Fixing sliders headings-letter-spacing header-side-width and header-s…
31b515d
fix invalid selector "> li because it was causing js error"
c475cf1
example DXB Slider implementation
416e3a1
Fixed sliders on layout-theme-settings.inc and header-theme-settings.inc
daed500
Fixed sliders on page_title-theme-settings.inc
b55e622
Fixed sliders on typography-theme-settings.inc
17a34f4
Fixed sliders on block-design-theme-settings.inc
579aa13
Small fix and commenting js generating sliders
be984c0
After eslint and drupal-lint; Removed commented code on dxpr-theme-se…
6796886
Merge remote-tracking branch 'origin/drale1/6.x/#526-jQuery-free-and-…
cfb399f
Fixed live slider change
37e8ba3
Additionally fixed layout-theme-settings.inc header-theme-settings.inc
c59ab3d
Additionally fixed page_title-theme-settings.inc typography-theme-set…
6bf22ff
Additionally fixed block-design-theme-settings.inc
85e1917
Added novalidate attribute to fix saving issue with sliders
5721f16
Fixed flex displaying in Typography
9d700c2
Fixed eslint issue and removed dynamic change from box-max-width layo…
3ed7801
fix grunt setup
fd88e07
Fix: Set Block Preset to custom only when a change is detected in Blo…
e1a428c
Hide divider sliders when block_divider and block_divider_custom are …
6b52445
Hide 'Boxed Container Max-width' slider when 'boxed_layout' is unchecked
83e23d2
Fixed Sticky Header Height max to 200
be11313
After eslint and drupal lint
aa85d0a
Removed eye from no-preview class from children from .form-radios and…
4e50e88
Manually removed eye from class no-preview in block_card and block_di…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,89 +1,106 @@ | ||
| module.exports = function(grunt) { | ||
| const sass = require('sass'); | ||
| const sass = require("sass"); | ||
| const autoprefixer = require("autoprefixer"); | ||
| const postcssPxtorem = require("postcss-pxtorem"); | ||
|
|
||
| module.exports = function (grunt) { | ||
| grunt.initConfig({ | ||
| pkg: grunt.file.readJSON('package.json'), | ||
| pkg: grunt.file.readJSON("package.json"), | ||
| babel: { | ||
| options: { | ||
| sourceMap: false | ||
| sourceMap: false, | ||
| }, | ||
| dist: { | ||
| files: { | ||
| 'js/minified/dxpr-theme-full-screen-search.min.js': 'js/dist/dxpr-theme-full-screen-search.js', | ||
| 'js/minified/dxpr-theme-header.min.js': 'js/dist/dxpr-theme-header.js', | ||
| 'js/minified/dxpr-theme-multilevel-mobile-nav.min.js': 'js/dist/dxpr-theme-multilevel-mobile-nav.js', | ||
| 'js/minified/dxpr-theme-settings.admin.min.js': 'js/dist/dxpr-theme-settings.admin.js', | ||
| 'js/minified/dxpr-theme-tabs.min.js': 'js/dist/dxpr-theme-tabs.js', | ||
deuxcode marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| } | ||
| "js/minified/dxpr-theme-full-screen-search.min.js": | ||
| "js/dist/dxpr-theme-full-screen-search.js", | ||
| "js/minified/dxpr-theme-header.min.js": | ||
| "js/dist/dxpr-theme-header.js", | ||
| "js/minified/dxpr-theme-multilevel-mobile-nav.min.js": | ||
| "js/dist/dxpr-theme-multilevel-mobile-nav.js", | ||
| "js/minified/dxpr-theme-settings.admin.min.js": | ||
| "js/dist/dxpr-theme-settings.admin.js", | ||
| "js/minified/dxpr-theme-tabs.min.js": "js/dist/dxpr-theme-tabs.js", | ||
| }, | ||
| }, | ||
| }, | ||
| terser: { | ||
| options: { | ||
| ecma: 2015 | ||
| ecma: 2015, | ||
| }, | ||
| main: { | ||
| files: { | ||
| 'js/minified/classie.min.js': ['vendor/classie.js'], | ||
| 'js/minified/dxpr-theme-full-screen-search.min.js': ['js/minified/dxpr-theme-full-screen-search.min.js'], | ||
| 'js/minified/dxpr-theme-header.min.js': ['js/minified/dxpr-theme-header.min.js'], | ||
| 'js/minified/dxpr-theme-multilevel-mobile-nav.min.js': ['js/minified/dxpr-theme-multilevel-mobile-nav.min.js'], | ||
| 'js/minified/dxpr-theme-settings.admin.min.js': ['js/minified/dxpr-theme-settings.admin.min.js'], | ||
| 'js/minified/dxpr-theme-tabs.min.js': ['js/minified/dxpr-theme-tabs.min.js'], | ||
deuxcode marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| } | ||
| "js/minified/classie.min.js": ["vendor/classie.js"], | ||
| "js/minified/dxpr-theme-full-screen-search.min.js": [ | ||
| "js/minified/dxpr-theme-full-screen-search.min.js", | ||
| ], | ||
| "js/minified/dxpr-theme-header.min.js": [ | ||
| "js/minified/dxpr-theme-header.min.js", | ||
| ], | ||
| "js/minified/dxpr-theme-multilevel-mobile-nav.min.js": [ | ||
| "js/minified/dxpr-theme-multilevel-mobile-nav.min.js", | ||
| ], | ||
| "js/minified/dxpr-theme-settings.admin.min.js": [ | ||
| "js/minified/dxpr-theme-settings.admin.min.js", | ||
| ], | ||
| "js/minified/dxpr-theme-tabs.min.js": [ | ||
| "js/minified/dxpr-theme-tabs.min.js", | ||
| ], | ||
| }, | ||
| }, | ||
| }, | ||
| sass: { | ||
| options: { | ||
| implementation: sass, | ||
| sourceMap: false, | ||
| outputStyle: 'compressed' | ||
| outputStyle: "compressed", | ||
| }, | ||
| dist: { | ||
| files: [{ | ||
| expand: true, | ||
| cwd: 'scss/', | ||
| src: '**/*.scss', | ||
| dest: 'css/', | ||
| ext: '.css', | ||
| extDot: 'last' | ||
| }] | ||
| } | ||
| files: [ | ||
| { | ||
| expand: true, | ||
| cwd: "scss/", | ||
| src: "**/*.scss", | ||
| dest: "css/", | ||
| ext: ".css", | ||
| extDot: "last", | ||
| }, | ||
| ], | ||
| }, | ||
| }, | ||
| postcss: { | ||
| options: { | ||
| processors: [ | ||
| require('autoprefixer'), | ||
| require('postcss-pxtorem')({ | ||
| autoprefixer, | ||
| postcssPxtorem({ | ||
| rootValue: 16, // The root element font size. | ||
| unitPrecision: 5, // The decimal precision. | ||
| propList: ['*'], // Properties to convert. | ||
| propList: ["*"], // Properties to convert. | ||
| selectorBlackList: [], // Selectors to ignore. | ||
| replace: true, // Replace the original value. | ||
| mediaQuery: true, // Allow px to be converted in media queries. | ||
| minPixelValue: 0 // Set the minimum pixel value to replace. | ||
| }) | ||
| ] | ||
| minPixelValue: 0, // Set the minimum pixel value to replace. | ||
| }), | ||
| ], | ||
| }, | ||
| dist: { | ||
| src: 'css/**/*.css' | ||
| } | ||
| src: "css/**/*.css", | ||
| }, | ||
| }, | ||
| watch: { | ||
| css: { | ||
| files: ['scss/*.scss', 'scss/**/*.scss'], | ||
| tasks: ['sass', 'postcss'] | ||
| files: ["scss/*.scss", "scss/**/*.scss"], | ||
| tasks: ["sass", "postcss"], | ||
| }, | ||
| js: { | ||
| files: ['js/dist/*.js'], | ||
| tasks: ['babel', 'terser'] | ||
| } | ||
| } | ||
| files: ["js/dist/*.js"], | ||
| tasks: ["babel", "terser"], | ||
| }, | ||
| }, | ||
| }); | ||
|
|
||
| grunt.loadNpmTasks('grunt-babel'); | ||
| grunt.loadNpmTasks('grunt-terser'); | ||
| grunt.loadNpmTasks('grunt-sass'); | ||
| grunt.loadNpmTasks('grunt-contrib-watch'); | ||
| grunt.loadNpmTasks('@lodder/grunt-postcss'); | ||
| grunt.registerTask('default', ['watch']); | ||
| grunt.loadNpmTasks("grunt-babel"); | ||
| grunt.loadNpmTasks("grunt-terser"); | ||
| grunt.loadNpmTasks("grunt-sass"); | ||
| grunt.loadNpmTasks("grunt-contrib-watch"); | ||
| grunt.loadNpmTasks("@lodder/grunt-postcss"); | ||
| grunt.registerTask("default", ["watch"]); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know some of these changes was in relation to the lint checks issue, but after the main merge, none of these changes are actually relevant to the issue. This whole file can be reverted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note that this file doesn't actually contain any relevant changes, but we can keep it as is.