FBORenderContextProvider optimization #145
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alariq
commented
Mar 2, 2018
| protected DIBSection dibSection = new DIBSection(); | ||
| protected OpenGL gl; | ||
|
|
||
| protected bool usePBO = false; |
Author
There was a problem hiding this comment.
Set this to true to enable PBO based optimization
|
@dwmkerr Could you estimate when or if this pull request will be merged? |
Author
|
I did this change quite a long time ago, but if you need my help let me know |
This was referenced May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses 2 interleaving OpenGL PixelBufferObjects for readback instead of syncing CPU to GPU all the time.
I've also incorporated here changes proposed by @ftlPhysicsGuy ( here: #121)
Additional improvement would be to not fill any intermediary structures and fill writeable image directly (as we are not using framebuffer of hidden window!)