Spotify OAuth2.0 Compliance Patch #336
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
current code fails to authenticate new users because of an update to OAuth2.0 security protocol. http://localhost: requests are no longer considered secure and spotify requires http://127.0.0.1: to be used instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minor revision to allow new users to login with lofi desktop client. previous code used localhost addresses in the auth.ts file which are no longer compatible with Spotify's dev API requirements (OAuth2.0), this revision replaces those with 127.0.0.1 which is the officially supported address to route API calls.
One small edit that I suggest before merging the files: in line 20 I had to replace the AUTH_CLIENT_ID = 'insert client ID' with my own from my personal Spotify Dev account. This was just to enable testing on my machine once I compiled the program. It will continue to work just fine if you choose to leave this in the merge, but please note that the CLIENT_ID will no longer be making a call to your team's Spotify dev account. No clue what the implications are here.