Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several major improvements and new features to configuration handling, user experience, and documentation for the project. The most significant changes include support for notification grouping and per-repository overrides, a new
[indicator]config section for system tray customization, improved config validation with actionable error messages, and enhanced documentation to reflect these capabilities.Configuration and Notification Enhancements:
Added support for notification grouping via a new
[notifications]TOML section; users can now choose between "flat" and "repo" grouping, and configure per-repo notification settings such as enabling/disabling notifications, urgency, and summary thresholds. [1] [2] [3] [4] [5] [6] [7] [8]Introduced a new
[indicator]TOML section allowing users to tune system tray indicator settings (reconnect_interval,window_width,max_window_height) without code changes. [1] [2] [3] [4] [5] [6]Validation and Error Handling Improvements:
Config validation now collects all errors and reports them in a single
ConfigErrorwith actionable hints, so users can fix every problem in one pass. Unknown config keys now produce warnings to help catch typos early. [1] [2] [3] [4] [5]Improved first-run experience:
ConfigErroris now caught and displayed as a user-friendly log message with remediation hints, and the daemon exits cleanly with code 1. Logging is initialized before config loading to ensure all errors are properly formatted. [1] [2]Documentation Updates:
Expanded documentation to describe the new
[notifications]and[indicator]sections, including configuration examples, validation rules, and Python API usage for loading and accessing these settings. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]Added new example configurations and clarified validation error messages with actionable hints (e.g., token prefix, recommended poll interval, repo format). [1] [2] [3]
Other Improvements:
These changes collectively provide more flexible configuration, better error reporting, and improved documentation for both users and developers.