Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and improvements to configuration handling, validation, and documentation for the project. The main focus is on making configuration more robust and user-friendly, adding support for indicator-specific settings, and improving error reporting and logging.
Key highlights:
[indicator]TOML section for system tray indicator settings, with a dedicatedIndicatorConfigdataclass and loader.Configuration and Validation Improvements
ConfigError, with actionable hints in error messages (e.g., token prefix examples, GitHub poll interval recommendations, and repo format examples). This allows users to fix all config issues in one pass. [1] [2] [3] [4] [5] [6]Indicator Configuration
[indicator]TOML section for system tray indicator settings (reconnect_interval,window_width,max_window_height), which can be configured without code changes. A newIndicatorConfigdataclass andload_indicator_config()function are introduced to load and validate these settings. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Documentation Updates
User Experience Enhancements
forgewatch setup, and invalid configs suggest checking the config file. [1] [2] [3]These changes make configuration more flexible, error reporting more helpful, and documentation more comprehensive, resulting in a smoother and more robust user experience.