add pagination cap warning and improve first-run experience#16
Merged
add pagination cap warning and improve first-run experience#16
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements two main improvements: it adds a warning when the poller hits the pagination cap and improves the first-run experience by handling config errors with user-friendly messages and clean exits. Logging is now initialised before config loading to ensure all errors are formatted and actionable. Corresponding documentation and tests have been updated to reflect these changes.
User experience improvements:
ConfigErrorduring startup and logs clear, actionable messages: if the config file is missing, the user is prompted to runforgewatch setup; if invalid, the user is told to check the config file. In both cases, the daemon exits cleanly with code 1. Logging is initialised before config loading to ensure all errors are properly formatted. [1] [2] [3] [4]Pagination and poller enhancements:
_MAX_PAGES) is reached and more results are available, suggesting the user narrow their repo filter. [1] [2] [3]Testing improvements:
Documentation and versioning:
1.5.0.devand updated the changelog. [1] [2]