PLUGIN-74. Google Sheets. Batch source. by dvitiiuk · Pull Request #10 · dvitiiuk/google-drive

dvitiiuk · 2019-11-25T10:38:39Z

Doc: https://wiki.cask.co/display/CE/Google+Sheets+plugins
Jira: https://issues.cask.co/browse/PLUGIN-74
Batch source for Google Sheets.

aonischuk · 2019-11-25T11:21:05Z

docs/GoogleSheets-batchsource.md

+
+**Skip Empty Data:** Field that allows skipping of empty structure records.
+
+**Add spreadSheet/sheet name fields:** Toggle that defines if the sink extends output schema with 


sink -> source

remove "For Yes selection the spreadSheet and sheet name fields can be specified via "

aonischuk · 2019-11-25T11:22:32Z

docs/GoogleSheets-batchsource.md

+
+**Sheet field name:** Schema field name for sheet name.
+
+**Column Names Selection:** Source for column names.


more details.

aonischuk · 2019-11-25T11:23:20Z

docs/GoogleSheets-batchsource.md

+
+**Column Names Selection:** Source for column names.
+
+**Custom Row For Column Names:** Row number of the row to be treated as a header.


"Number of the row"

aonischuk · 2019-11-25T11:23:50Z

docs/GoogleSheets-batchsource.md

+
+**Last Data Row:** Last row number of the maximal field of plugin work for data.
+
+**Read Buffer Size:** Number of rows the source reads by single API request.


by -> with a

aonischuk · 2019-11-25T11:24:46Z

docs/GoogleSheets-batchsource.md

+
+**Last Data Column:** Last column number of the maximal field of plugin work for data.
+
+**Last Data Row:** Last row number of the maximal field of plugin work for data.


Last row plugin will read.

aonischuk · 2019-11-25T12:30:10Z

src/main/java/io/cdap/plugin/google/sheets/source/utils/ColumnAddressConverter.java

+  public static int getNumberOfColumn(String columnName) {
+    int sum = 0;
+    final int base = 26;
+    final int sub = 64;


no magic numbers. Add a private static final with a comment.

aonischuk · 2019-11-25T12:32:44Z

widgets/GoogleSheets-batchsource.json

+          "label": "First Header Row",
+          "name": "firstHeaderRow",
+          "widget-attributes": {
+            "default": "-1",


is it possible to make it null default instead?

aonischuk · 2019-11-25T12:37:01Z

widgets/GoogleSheets-batchsource.json

+    {
+      "name": "Select modification date range",
+      "condition": {
+        "expression": "modificationDateRange == 'custom'"


if possible we should always use "equalTo" or other predefined checks.
https://github.com/data-integrations/http/blob/06fca99995efac5f7f15147b5489dd3c493316a3/widgets/HTTP-batchsource.json#L523

aonischuk · 2019-11-25T12:38:19Z

widgets/GoogleSheets-batchsource.json

+    {
+      "name": "Authenticate with OAuth2",
+      "condition": {
+        "expression": "authType == 'oAuth2'"


same for others

aonischuk · 2019-11-25T12:38:54Z

src/main/java/io/cdap/plugin/google/sheets/source/utils/ColumnComplexSchemaInfo.java

+  private Schema dataSchema;
+  private List<ColumnComplexSchemaInfo> subColumns = new ArrayList<>();
+
+  public ColumnComplexSchemaInfo(String headerTitle/*, int index*/, Schema dataSchema) {


remove the comment.

aonischuk suggested changes Nov 25, 2019

View reviewed changes

dvitiiuk force-pushed the PLUGIN-74-google-sheets-sink branch 3 times, most recently from 324a80f to 7e4f904 Compare November 25, 2019 18:48

dvitiiuk force-pushed the PLUGIN-74-google-sheets-source branch 4 times, most recently from 391f45e to 8621057 Compare November 26, 2019 21:10

dvitiiuk force-pushed the PLUGIN-74-google-sheets-sink branch from 7e4f904 to a5408f3 Compare November 26, 2019 21:22

dvitiiuk force-pushed the PLUGIN-74-google-sheets-source branch 2 times, most recently from 8335306 to a340cb9 Compare November 26, 2019 21:27

dvitiiuk force-pushed the PLUGIN-74-google-sheets-sink branch from a5408f3 to ce1a6cc Compare November 26, 2019 21:28

PLUGIN-74. Google Sheets. Batch source.

4625204

dvitiiuk force-pushed the PLUGIN-74-google-sheets-source branch from a340cb9 to 4625204 Compare November 26, 2019 21:39


		Skip Empty Data: Field that allows skipping of empty structure records.

		Add spreadSheet/sheet name fields: Toggle that defines if the sink extends output schema with


		Sheet field name: Schema field name for sheet name.

		Column Names Selection: Source for column names.


		Column Names Selection: Source for column names.

		Custom Row For Column Names: Row number of the row to be treated as a header.


		Last Data Row: Last row number of the maximal field of plugin work for data.

		Read Buffer Size: Number of rows the source reads by single API request. No newline at end of file


		Last Data Column: Last column number of the maximal field of plugin work for data.

		Last Data Row: Last row number of the maximal field of plugin work for data.

Conversation

dvitiiuk commented Nov 25, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants