Docker support up to v29, cleaned up the code, and fixed some bugs. #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Append domain name to host name
Only attempt lines trim if the list isn't empty
Handle container rename
Includes .idea and .venv directories to be ignored by Git.
Exclude generated hosts file from version control.
Refactored the Docker event handling to use json parsing for more robust event processing. Updated the hosts file update logic to correctly handle existing sections and ensure atomic writes. Improved container info extraction and error handling.
Includes necessary libraries such as certifi, charset-normalizer, docker, idna, requests, and urllib3.
Add new copyright holder to LICENSE file.
Replaced 'frolvlad/alpine-python3' with 'python:3.14-alpine'. Modified installation to use requirements.txt for dependencies. Updated COPY commands for hoster.py and requirements.txt.
Introduces a Dockerfile for building images, a .dockerignore file to exclude unnecessary files, and a GitHub Actions workflow for automatically building and pushing Docker images to GHCR upon release.
Converts the GitHub repository name to lowercase when constructing the `IMAGE_NAME` for pushing to GitHub Container Registry. This ensures consistency and avoids potential issues with case-sensitive image names.
Ensures the repository name used in the Docker image tag is always lowercase for consistency.
The default docker socket path in hoster.py has been updated from "tmp/docker.sock" to "/tmp/docker.sock" to match the Dockerfile's VOLUME mounting. The Dockerfile has also been updated to use ENTRYPOINT and CMD for better container execution, and the README.md has been updated with the new image name.
Changed dockerClient initialization to None to defer client creation until needed. This may prevent issues with early initialization in certain environments.
Retrieve container ID from 'Actor.ID' and add validation
Improved project description, quick start, and container registration details.
|
This project appears to be unmaintained. It would be great if someone created a fork and continued its development. |
Author
I’ve created a fork, and it’s fully functional with multiple bug fixes: |
|
https://github.com/wollomatic/container-hoster There's also my rewrite in Go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Change List
docker.APIClienttodocker.DockerClientfor modern API compatibility.hoster.domains).Brief Explanation of Changes and Why
The core updates modernize the Docker API usage and fix bugs like improper hosts file truncation (which lost user-added content) to make the script more reliable and robust—essential for production use. Label support adds flexibility for custom domains, previously unused. Event and file handling improvements prevent crashes and ensure consistency. Formatting changes align with standard
/etc/hostspractices for better readability. Docker package update ensures compatibility with recent Docker releases, avoiding deprecation issues. Python 3.14 upgrade leverages new features like improved error messages and performance. The GitHub Action automates image building/storing on tags, streamlining CI/CD for easier deployments and versioning. All changes keep the script concise while enhancing maintainability.