This repository was archived by the owner on Jan 25, 2026. It is now read-only.
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the S3 bucket policy by adding an explicit statement identifier for CloudFront read access.
- Introduces
Sidto the existingaws_s3_bucket_policystatement. - No functional behavior changes beyond metadata clarity.
Comments suppressed due to low confidence (2)
Modules/S3/main.tf:89
- [nitpick] Consider using the
aws_iam_policy_documentdata source to assemble bucket policy statements, improving readability and reuse.
Statement = [
Modules/S3/main.tf:91
- Run
terraform fmtto ensure the newSidline is aligned with the project's formatting conventions.
Sid = "AllowCloudFrontServiceReadAccess"
jongwooo
deleted the
chore/add-sid-to-s3-bucket-policy-for-clearer-statement-identification
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes a small change to the
Modules/S3/main.tffile. The change adds aSidfield to theaws_s3_bucket_policyresource to specify the statement identifier for allowing CloudFront service read access.