This repository was archived by the owner on Jan 25, 2026. It is now read-only.
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR expands the S3 bucket policy to include object deletion in addition to object creation.
- Renames the policy statement ID to reflect both put and delete actions
- Adds
s3:DeleteObjectalongsides3:PutObjectin allowed actions
Comments suppressed due to low confidence (2)
Modules/S3/main.tf:58
- [nitpick] Update any module README or documentation to mention the new
AllowPutAndDeleteAccessstatement and the inclusion of delete permissions so users are aware of the expanded scope.
Sid = "AllowPutAndDeleteAccess"
Modules/S3/main.tf:61
- [nitpick] Consider adding or updating automated tests (e.g., using Terraform plan validation) to verify that both
s3:PutObjectands3:DeleteObjectare correctly included in the bucket policy.
Action = [
jongwooo
deleted the
chore/add-delete-object-action-to-asset-bucket-policy
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes a modification to the
aws_s3_bucket_policyresource inModules/S3/main.tf. The change updates the policy to expand the allowed actions for the bucket.Policy update:
Modules/S3/main.tf: Changed theSidvalue fromAllowWriteAccesstoAllowPutAndDeleteAccessand addeds3:DeleteObjectto the list of allowed actions, alongsides3:PutObject. This expands the permissions to include object deletion.