Open
Conversation
added 6 commits
June 3, 2018 19:47
Author
|
This is failing because of:
I would like to do this... --- a/clamd.go
+++ b/clamd.go
@@ -26,7 +26,6 @@ SOFTWARE.
package clamd
import (
- "errors"
"fmt"
"io"
"net/url"
@@ -125,7 +124,7 @@ func (c *Clamd) Ping() error {
case "PONG":
return nil
default:
- return errors.New(fmt.Sprintf("Invalid response, got %s.", s))
+ return fmt.Errorf("Invalid response, got %v.", s)
}
}
}
@@ -186,7 +185,7 @@ func (c *Clamd) Reload() error {
case "RELOADING":
return nil
default:
- return errors.New(fmt.Sprintf("Invalid response, got %s.", s))
+ return fmt.Errorf("Invalid response, got %v.", s)
}
}
}but I am not sure about the GO 1.1, 1.2 and 1.3 in the travis file, are you happy for me to remove them and bump the test versions to be 1.9 and 1.10? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I love this module and its helped me out a lot, or saved me some pain porting over a Perl version.
I have ran through the code updated some bits an pieces, its certainly not a comprehensive look.
Feel free to use or not use anything here.
Regards