Allow changing chunk size for ScanStream#15
Open
gergof wants to merge 2 commits intodutchcoders:masterfrom
Open
Allow changing chunk size for ScanStream#15gergof wants to merge 2 commits intodutchcoders:masterfrom
gergof wants to merge 2 commits intodutchcoders:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added chunkSize parameter to Clamd struct which is used now instead of the default value of 1024.
Also replaced the abort channel with type struct{} so it can be used out of the box with the ctx.Done() channel.
Added a builder to not change the function signatures for Clamd and added a module file.