Introduce Scanner interface as an abstraction for Clamd struct#10
Open
legosx wants to merge 2 commits intodutchcoders:masterfrom
Open
Introduce Scanner interface as an abstraction for Clamd struct#10legosx wants to merge 2 commits intodutchcoders:masterfrom
legosx wants to merge 2 commits intodutchcoders:masterfrom
Conversation
Contributor
|
Do we really need a single interface containing all methods? Would it not be better to split it up in multiple smaller logical chunks? Wrt to your return argument. How does it pertain to the guideline of 'accept interfaces, return structs'? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For testing purposes I would like to have an interface as an abstraction from Clamd.
Pull Request is just adding the interface without changing any logic.
The name
Scannercan be discussed but I think that it represents the methods inside of the interface.