Skip to content

Added sanity check to width and height #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dustout merged 1 commit into from
May 24, 2025
Merged

Added sanity check to width and height #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CommonImageActions.AspNetCore/CommonImageActionSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ public string PathToWatch

public static string DefaultDiskCacheLocation { get; set; }

public static int MaxUrlWidth { get; set; } = 5000;

public static int MaxUrlHeight { get; set; } = 5000;

public static string[] ValidImageExtensions = {
".bmp",
".gif",
Expand Down
12 changes: 10 additions & 2 deletions CommonImageActions.AspNetCore/CommonImageActionsMiddleware.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,13 +281,21 @@ public static ImageActions ConvertQueryStringToImageActions(string queryString,
var widthString = query["width"] ?? query["w"];
if (int.TryParse(widthString, out int width))
{
imageActions.Width = width;
//sanity check to make sure no bad actor requests a number that may eat all the ram in the system
if(width < CommonImageActionSettings.MaxUrlWidth)
{
imageActions.Width = width;
}
}

var heightString = query["height"] ?? query["h"];
if (int.TryParse(heightString, out int height))
{
imageActions.Height = height;
//sanity check to make sure no bad actor requests a number that may eat all the ram in the system
if (width < CommonImageActionSettings.MaxUrlHeight)
{
imageActions.Height = height;
}
}

var pageString = query["Page"] ?? query["p"];
Expand Down
Loading