Skip to content

Add option to disable transformations.#2

Open
bobobo1618 wants to merge 1 commit intodustin:masterfrom
bobobo1618:master
Open

Add option to disable transformations.#2
bobobo1618 wants to merge 1 commit intodustin:masterfrom
bobobo1618:master

Conversation

@bobobo1618
Copy link
Copy Markdown

Creating heatmaps to be overlaid on Google Maps requires precisely
controlling the projection and scale of plotted points. The
transformation feature doesn't fit this use case well so the option to
disable it is handy.

Creating heatmaps to be overlaid on Google Maps requires precisely
controlling the projection and scale of plotted points. The
transformation feature doesn't fit this use case well so the option to
disable it is handy.
@bobobo1618
Copy link
Copy Markdown
Author

Before accepting this, could you possibly add a license to the repo to make it clear what the conditions for use are? I'd be fine with GPL but something like MIT or BSD would be nice.

Also I've found that when feeding in co-ordinates, I often find them upside-down when using the translate function.

@dustin
Copy link
Copy Markdown
Owner

dustin commented Sep 16, 2015

I'm not a GPL fan... Added an MIT thing copied from another repo.

Do you have an example of the difference this produces?

On Wed, Sep 16, 2015 at 8:34 AM bobobo1618 notifications@github.com wrote:

Before accepting this, could you possibly add a license to the repo to
make it clear what the conditions for use are? I'd be fine with GPL but
something like MIT or BSD would be nice.

Also I've found that when feeding in co-ordinates, I often find them
upside-down when using the translate function.


Reply to this email directly or view it on GitHub
#2 (comment).

@bobobo1618
Copy link
Copy Markdown
Author

Thanks!

I don't have images on hand right now but if you want them for docs I'll
add some later tonight. If you wanted them to see what my code does, if I
have a set of GPS coordinates from LA mapped using the Mercator projection
and scaled to meet my required image size, the existing code 'zooms in' on
LA while my new code maintains a worldwide view.

On Wed, 16 Sep 2015, 08:43 Dustin Sallings notifications@github.com wrote:

I'm not a GPL fan... Added an MIT thing copied from another repo.

Do you have an example of the difference this produces?

On Wed, Sep 16, 2015 at 8:34 AM bobobo1618 notifications@github.com
wrote:

Before accepting this, could you possibly add a license to the repo to
make it clear what the conditions for use are? I'd be fine with GPL but
something like MIT or BSD would be nice.

Also I've found that when feeding in co-ordinates, I often find them
upside-down when using the translate function.


Reply to this email directly or view it on GitHub
#2 (comment).


Reply to this email directly or view it on GitHub
#2 (comment).

@bobobo1618
Copy link
Copy Markdown
Author

Here's an example using a randomly generated sample of points between 1 and 256 on a 1024x1024 heatmap:

Before my change (transform=true):

test2

The 256x256 blob is expanded to take up the full 1024x1024 image.

After my change (transform=false):

test1

The 256x256 blob is left in the corner it was generated in, fitting well into situations where precise location is needed for things like map overlays.

@Rossiar
Copy link
Copy Markdown

Rossiar commented Jun 12, 2018

@dustin I'm happy to fix this up and merge - is it ok with you? As @bobobo1618 points out, the data is "stretched" into whatever size image is given and this is not desired for my use case.

@GarrettKelley
Copy link
Copy Markdown

This exact use case came up for me on a project recently, I copied the contents of the PR into my local clone, but it would be nice to see this get merged at some point

@cmitchell
Copy link
Copy Markdown

I second @Rossiar 's suggestion of getting this merged.

@Icaro-Lima
Copy link
Copy Markdown

This is exactly i need!

@dustin
Copy link
Copy Markdown
Owner

dustin commented Feb 26, 2019

I've apparently completely forgotten about this. I think it would be fine since it seems to be useful for people.

@dustin
Copy link
Copy Markdown
Owner

dustin commented Feb 26, 2019

Is there a test case that works reasonably here? I updated the commit to build properly, but my test data + no transform = doesn't seem to do anything.

@andersfylling
Copy link
Copy Markdown

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants