Open
Conversation
duncancmt
reviewed
Nov 22, 2025
Owner
duncancmt
left a comment
duncancmt
left a comment
There was a problem hiding this comment.
This looks like a good skeleton for a unit test suite. Please merge in the latest changes from dcmt/yoga-contract to make sure that we're on the same page.
The main thing that should be improved here is that we want to exercise more of the codepaths of _populateActions and check that it's not somehow corrupting the getTicks array. Because there are many many codepaths there, this will probably be a tedious task. This is a good place to begin to apply stateful invariant testing. But a few basic manual tests of those codepaths is probably a good idea too.
Collaborator
Author
|
Acknowledged^ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.