Skip to content

Conversation

@jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Dec 19, 2025

Asana Task/Github Issue: N/A

Description

Consolidates Playwright test server configurations by:

  • Removing the altServerPort fixture and its associated per-test forked server.
  • Unifying fingerprint tests to use a single Playwright webServer instance, leveraging different hosts (localhost and 127.0.0.1) on the same port for first-party separation.
  • Centralizing Playwright server port and base URL definitions.
  • Deleting the now-unused injected/scripts/server.mjs.

This streamlines the test setup and removes redundant server logic introduced during the Playwright migration.

Testing Steps

  • Run npm run build and ensure injected unit tests pass.
  • Run npm run test-int-x -- --project chrome-mv3 --grep "Fingerprint" and ensure fingerprint Playwright tests pass.

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Open in Cursor Open in Web


Note

Centralizes Playwright server port/base URL, removes the per-test forked server/altServerPort fixture, updates fingerprint tests to use a single webServer on one port across hosts, and deletes the obsolete server script.

  • Test infrastructure:
    • Centralize server config with TEST_PAGE_SERVER_PORT and TEST_PAGE_SERVER_BASE_URL in injected/playwright.config.js; set webServer.port and use.baseURL accordingly.
    • Remove altServerPort fixture and per-test forked server from integration-test/helpers/harness.js and delete scripts/server.mjs.
  • Fingerprint tests (integration-test/fingerprint.spec.js):
    • Use shared TEST_PAGE_SERVER_PORT and a single Playwright webServer; test via localhost and 127.0.0.1 on the same port.
    • Drop altServerPort usage and related logging; minor refactors to test setup.

Written by Cursor Bugbot for commit fd7b66f. This will update automatically on new commits. Configure here.

Removes the http-server dependency and simplifies the test harness by removing the need for a separate server process.

Co-authored-by: jkingston <jkingston@duckduckgo.com>
@cursor
Copy link

cursor bot commented Dec 19, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@netlify
Copy link

netlify bot commented Dec 19, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit fd7b66f
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/694567d4114df70008c2fb3b
😎 Deploy Preview https://deploy-preview-2130--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

[Beta] Generated file diff

Time updated: Fri, 19 Dec 2025 16:12:25 GMT

@jonathanKingston jonathanKingston marked this pull request as ready for review December 19, 2025 16:11
@jonathanKingston jonathanKingston requested a review from a team as a code owner December 19, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants